[Webkit-unassigned] [Bug 90381] [JSBinding] Merging jsUnsignedLongArrayToVector() to toNativeArray() using traits.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=90381





--- Comment #3 from Vineet Chaudhary (vineetc) <rgf748 at motorola.com>  2012-07-02 06:37:32 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=150411&action=review

Thanks haraken for review comments.
Actually I had couple doubts as below.

> Source/WebCore/bindings/js/JSDOMBinding.h:-409
> -        JSC::JSObject* object = toJSSequence(exec, value, length);

In this implementation it uses toJSSequence(). As per comment this "Validates that the passed object is a sequence type per section 4.1.13 of the WebIDL spec." 
http://trac.webkit.org/browser/trunk/Source/WebCore/bindings/js/JSDOMBinding.h#L347
But I couldn't understand how it validates. If it does nothing can we eliminate these steps?

> Source/WebCore/bindings/scripts/test/TestObj.idl:203
> +        void methodWithSequenceUnsignedLong(in sequence<unsigned long> unsignedLongSequence);

As we support sequence<T> as method argument should we change
http://trac.webkit.org/browser/trunk/Source/WebCore/Modules/vibration/NavigatorVibration.idl#L26

void webkitVibrate(in unsigned long[] pattern) raises(DOMException);  //TO

void webkitVibrate(in sequence<unsigned long> pattern) raises(DOMException);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.