[Webkit-unassigned] [Bug 90166] NEON intrinsics should be used with gaussian blur filter

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 2 04:33:05 PDT 2012


https://bugs.webkit.org/show_bug.cgi?id=90166





--- Comment #5 from Zoltan Herczeg <zherczeg at webkit.org>  2012-07-02 04:33:05 PST ---
(From update of attachment 150397)
View in context: https://bugs.webkit.org/attachment.cgi?id=150397&action=review

> Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp:127
> +            if (!isAlphaImage())
> +                boxBlurNEON(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride, paintSize.width(), paintSize.height(), isAlphaImage());
> +            else
> +                boxBlur(src, dst, kernelSizeX, dxLeft, dxRight, 4, stride, paintSize.width(), paintSize.height(), isAlphaImage());

Since isAlphaImage() is known at this point, we should pass true to boxBlur and remove the bool argument from boxBlurNEON. If we ever make an alpha based version, it will have a different name, since the code cannot be shared.

> Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h:32
> +using namespace std;

We should not add using to a header file... We should use std:: if it is really needed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list