[Webkit-unassigned] [Bug 90198] Port DFG JIT to traditional ARM
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 2 03:43:34 PDT 2012
https://bugs.webkit.org/show_bug.cgi?id=90198
--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-07-02 03:43:33 PST ---
Attachment 150392 did not pass style-queue:
Source/JavaScriptCore/assembler/MacroAssemblerARM.h:1205: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/JavaScriptCore/dfg/DFGOperations.cpp:146: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:157: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:178: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:189: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:1382: Extra space before ( in function call [whitespace/parens] [4]
Source/JavaScriptCore/dfg/DFGOperations.cpp:1391: The parameter name """" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.cpp:295: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/JavaScriptCore/assembler/ARMAssembler.cpp:331: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:433: vmov_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:468: vabs_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:473: vneg_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:488: dtr_u is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:493: dtr_ur is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:498: dtr_d is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:503: dtr_dr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:508: dtrh_u is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:513: dtrh_ur is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:518: dtrh_d is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:523: dtrh_dr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:528: fdtr_u is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:535: fdtr_d is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:564: vmov_vfp64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:570: vmov_arm64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:576: vmov_vfp32_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:582: vmov_arm32_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:600: vcvt_u32_f64_r is incorrectly named. DoFailed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/assembler/ARMAssembl..." exit_code: 1
n't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:606: vcvt_f64_f32_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:612: vcvt_f32_f64_r is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/JavaScriptCore/assembler/ARMAssembler.h:932: Extra space before last semicolon. If this should be an empty statement, use { } instead. [whitespace/semicolon] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:949: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:950: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:951: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:952: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:953: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/JavaScriptCore/assembler/ARMAssembler.h:954: The parameter name "type" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 36 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list