[Webkit-unassigned] [Bug 83865] [EFL] Add Web Inspector to WebKit-EFL

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=83865





--- Comment #22 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2012-07-01 21:50:05 PST ---
(From update of attachment 150085)
View in context: https://bugs.webkit.org/attachment.cgi?id=150085&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:44
> +#include "InspectorController.h"

Hmm, I don't know why style checker didn't find this style error. Adhere alphabetic order.

> Source/WebKit/efl/ewk/ewk_view.h:2686
> +EAPI void ewk_view_web_inspector_view_set(Evas_Object* o, Evas_Object* obj);

If possible, I think we need to use more meaningful parameter name. Is it better to use inspector_view ?

In addition, move * to variable side.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.