[Webkit-unassigned] [Bug 77513] webkit-perf.appspot.com should accept test results without medians

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77513





--- Comment #3 from Ryosuke Niwa <rniwa at webkit.org>  2012-01-31 23:46:20 PST ---
(In reply to comment #2)
> (From update of attachment 124889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124889&action=review
> 
> r=me. Sometime we should have test for this.

Yeah... Unfortunately, App Engine doesn't have any testing framework for python the last time I checked :(

> > Websites/webkit-perf.appspot.com/report_handler.py:99
> > +                TestResult(name=test_name, build=build, value=float(result['avg']), valueMedian=_float_or_none(result, 'median'),
> 
> Considering TestResult.value is required field, this change looks reasonable.

Yes. In fact, _results_are_valid checks the existence of this value.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.