[Webkit-unassigned] [Bug 76611] Content element should be able to be dynamically added/removed/replaced in a shadow tree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76611





--- Comment #21 from Shinya Kawanaka <shinyak at chromium.org>  2012-01-31 20:02:32 PST ---
(In reply to comment #20)
> (From update of attachment 124862 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124862&action=review
> 
> > Source/WebCore/dom/Element.cpp:953
> > +        // In a shadow tree, some of light children may be attached by 'content' element.
> > +        // However, when there is no content element or content element does not select
> > +        // all light children, we have to attach the rest of light children here.
> 
> Won't this cause the children to appear in rendering? This seems wrong.

No, the children won't appear in rendering.

In WebCore::NodeRenderingContext, rendering of these elements are skipped.
You can find the code to skip them if m_phase is AttachContentLight.

And let me mention that actually the light children have been attached before this change.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.