[Webkit-unassigned] [Bug 76720] [chromium] Refactor video drawing to be more data driven

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76720





--- Comment #22 from Adrienne Walker <enne at google.com>  2012-01-31 17:41:41 PST ---
(From update of attachment 124742)
View in context: https://bugs.webkit.org/attachment.cgi?id=124742&action=review

Thanks for all of this.  Since you added willDraw in both this patch and the plugin patch, I think you'll have to let one of them land first and then rebase the other on top of ToT.

jamesr, what do you think?

> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:739
> +void LayerRendererChromium::drawCommon(const CCVideoDrawQuad* quad, Program* program, float widthScaleFactor, Platform3DObject textureId)

nit: Can you call this something else, like drawSingleTextureVideoQuad? drawCommon is a lot less meaningful of a name when moved to LRC.

(I also feel like this is yet another set of Programs that could be merged together, but I suppose those can all be done in another changelist.)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.