[Webkit-unassigned] [Bug 77267] Make WebGL put synthesized errors in the JS console

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77267





--- Comment #6 from Gregg Tavares <gman at google.com>  2012-01-31 16:48:36 PST ---
(From update of attachment 124415)
View in context: https://bugs.webkit.org/attachment.cgi?id=124415&action=review

I fixed the typos and the blendFuncSeparate issue. I also added a flag m_synthesizedErrorsToConsole which defaults to false. I'll use another CL to turn it on through Settings.h for Chrome only. That way hopefully DRT won't need new expectations

>> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:979
>> +    if (isContextLost() || !validateBlendFuncFactors("blendFunc", srcRGB, dstRGB) || !validateBlendFuncFactors("blendFunc", srcAlpha, dstAlpha))
> 
> The additional call to validateBlendFuncFactors checking srcAlpha and dstAlpha isn't correct. The restrictions on srcRGB and dstRGB don't apply to the alpha factors. See the spec and ANGLE's glBlendFuncSeparate in src/libGLESv2/libGLESv2.cpp.

done

>> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2027
>> +        synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "generateMipmaps", "level 0 not power of 2 or not all the same size");
> 
> generateMipmaps -> generateMipmap

done

>> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2077
>> +    if (isContextLost() || !validateWebGLObject("getAttachedShader", program))
> 
> getAttachedShader -> getAttachedShaders

done

>> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3136
>> +        synthesizeGLError(GraphicsContext3D::INVALID_OPERATION, "rendebufferStorage", "no bound renderbuffer");
> 
> rendebufferStorage -> renderbufferStorage

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.