[Webkit-unassigned] [Bug 71143] [Meta] Master bug for sub-pixel layout branch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=71143





--- Comment #15 from Emil A Eklund <eae at chromium.org>  2012-01-31 15:15:16 PST ---
(From update of attachment 124651)
View in context: https://bugs.webkit.org/attachment.cgi?id=124651&action=review

>> Source/WebKit/win/WebCoreSupport/WebChromeClient.cpp:118
>> +    return static_cast<IntRect>(rect);
> 
> Seems like many of these rounding changes could/should be done first.  We're not changing types here, you're just making more explicit what's going on, or?

Correct, the reason we cast platform specific types to their webkit equivalent is to avoid ambiguity. There aren't too many places where we do this but if you think it makes sense I'd gladly break those changes out into a separate patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.