[Webkit-unassigned] [Bug 75553] [GTK][WK2] Initial FullScreen support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75553


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124729|review?                     |review-
               Flag|                            |




--- Comment #26 from Martin Robinson <mrobinson at webkit.org>  2012-01-31 14:15:23 PST ---
(From update of attachment 124729)
View in context: https://bugs.webkit.org/attachment.cgi?id=124729&action=review

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.cpp:32
> +#include <WebCore/PlatformScreen.h>
> +
> +#include <gdk/gdk.h>

Please remove the extra newline here.

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:48
> +    GRefPtr<WebKitWebViewBase> m_webViewBase;

This actually means that all WebKitWebViewBase will leak because the WebViewBase owns the fullscreen controller and the fullscreen controller holds a reference. :)

> Source/WebKit2/UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:32
>  #include "WebProcess.h"
>  
>  #include <WebCore/NotImplemented.h>

Please remove the extra newline here.

> Source/WebKit2/UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:60
> +    WebKitWebViewBase* webViewBase = WEBKIT_WEB_VIEW_BASE(m_webView);
> +    FullScreenWindowController& controller = webkitWebViewBaseFullscreenWindowController(webViewBase);
> +    controller.exitFullScreen();

This can be one line.

> Source/WebKit2/UIProcess/gtk/WebFullScreenManagerProxyGtk.cpp:100
> +    FullScreenWindowController& controller = webkitWebViewBaseFullscreenWindowController(webViewBase);
> +    rect = controller.getFullScreenRect();

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.