[Webkit-unassigned] [Bug 77006] [StorageTracker] Make one able to set the local storage (tracker) database dir's path

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77006





--- Comment #17 from Anton D'Auria <adauria at apple.com>  2012-01-31 13:58:52 PST ---
(In reply to comment #16)
> (In reply to comment #14)
> > > Source/WebCore/storage/StorageTracker.cpp:101
> > > +    if (!m_database.isOpen())
> > 
> > you mean, if (m_database.isOpen())
> 
> Oh, sorry, fixed.
> 
> > m_originSetGuard needs to be unlocked because it's locked again in importOriginIdentifiers()
> > this will work:
> > {
> >     MutexLocker lockOrigins(m_originSetGuard);
> >     m_originSet.clear();
> > }
> 
> Yeah, got this lock-unlock idiom, now. Thanks for pointing out.
> Is the patch acceptable now?

It looks like you didn't test the previous patch before submitting it for review :) Can you please make sure this one is tested? The patch looks good to me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.