[Webkit-unassigned] [Bug 49543] [GTK] Improve FrameLoader signals. Resource loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49543


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124721|review?                     |review+
               Flag|                            |




--- Comment #33 from Martin Robinson <mrobinson at webkit.org>  2012-01-31 13:43:36 PST ---
(From update of attachment 124721)
View in context: https://bugs.webkit.org/attachment.cgi?id=124721&action=review

Okay. Thanks!

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:344
> +            (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),

Please use static_cast here.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:365
> +            (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),

Ditto.

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:384
> +            (GSignalFlags)(G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION),

Ditto and for the rest of the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.