[Webkit-unassigned] [Bug 77149] WebGL conformance test misc/functions-returning-strings.html fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77149


Kenneth Russell <kbr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124741|review?                     |review-
               Flag|                            |




--- Comment #6 from Kenneth Russell <kbr at google.com>  2012-01-31 11:34:31 PST ---
(From update of attachment 124741)
View in context: https://bugs.webkit.org/attachment.cgi?id=124741&action=review

Looks good overall; r- for a couple of relatively minor issues. Unfortunately I don't think it's possible to get the full test logs off the EWS bots; if you haven't already, build DumpRenderTree in your Chromium workspace and use src/webkit/tools/layout_tests/run_webkit_tests.sh to check the expected results. I'm doing this now and will update this bug if anything turns up.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:5125
> +      return WTF::emptyString();

4 space indent. (Style queue should have caught this.)

> Tools/ChangeLog:5
> +        https://bugs.webkit.org/show_bug.cgi?id=77149

Please split this change off into a second bug.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.