[Webkit-unassigned] [Bug 77179] getIntersectionList causes transforms to be recalculated in SVG
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 31 11:06:34 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=77179
--- Comment #6 from Philip Rogers <pdr at google.com> 2012-01-31 11:06:34 PST ---
(In reply to comment #4)
> Created an attachment (id=124746)
--> (https://bugs.webkit.org/attachment.cgi?id=124746&action=review) [details]
> Patch (+ test)
>
> Added a test following a discussion with pdr in #ksvg.
I think this change looks good overall.
A couple very minor nits: I think git is messing up the png in your ChangeLog, which is causing the style guide to complain.
A common pattern in pixel tests is to have an untranslated green square as "pass". Could you make the initial rotation be 0 or add a comment in the test describing that a rotated green square should be considered passing? This will make it easier for sheriffs/rebaseliners. One way would be to rotate the entire svg element by -50deg.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list