[Webkit-unassigned] [Bug 60010] [Chromium]Add clear_autofill flag to hide autofill popup without clear field.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 31 09:54:56 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=60010


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #92677|                            |review-
               Flag|                            |




--- Comment #30 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2012-01-31 09:54:55 PST ---
(From update of attachment 92677)
View in context: https://bugs.webkit.org/attachment.cgi?id=92677&action=review

>> Source/WebKit/chromium/public/WebView.h:301
>> +    virtual void acceptCurrectAutoFilled() = 0;
> 
> nit: Is there any reason not to name this more generally, e.g. """ acceptSelectedPopupItem() """ ?

Agreed, the name is wrong.  At the very least, it seems like you probably meant to write "Current" instead of "Currect", but I like Ilya's suggestion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list