[Webkit-unassigned] [Bug 77421] Parent SVGFontFaceElements style declaration to the rule

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77421


Adam Roben (:aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124702|review?                     |review+
               Flag|                            |




--- Comment #3 from Adam Roben (:aroben) <aroben at apple.com>  2012-01-31 06:52:28 PST ---
(From update of attachment 124702)
View in context: https://bugs.webkit.org/attachment.cgi?id=124702&action=review

> Source/WebCore/css/CSSFontFaceRule.cpp:36
> -    // FIXME: SVGFontFaceElement's style declaration should probably be parented to the rule too.
> -    if (m_style && !m_style->isElementStyleDeclaration())
> -        m_style->clearParentRule();
> +    m_style->clearParentRule();

Why do we now know m_style cannot be null? You should explain in the ChangeLog.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.