[Webkit-unassigned] [Bug 49543] [GTK] Improve FrameLoader signals. Resource loading

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=49543





--- Comment #29 from Gustavo Noronha (kov) <gns at gnome.org>  2012-01-31 04:07:34 PST ---
(From update of attachment 93083)
View in context: https://bugs.webkit.org/attachment.cgi?id=93083&action=review

> Source/WebKit/gtk/webkit/webkitwebframe.cpp:106
> +    RESOURCE_LOADING_FINISHED,

It all looks OK to me, the only thing that bothered me was using 'loading' only for this signal, I think we should be consistent and use load everywhere?

> Source/WebKit/gtk/webkit/webkitwebresource.cpp:51
> +    LOADING_FINISHED,

Ditto.

>> Source/WebKit/gtk/webkit/webkitwebview.cpp:185
>>      DOCUMENT_LOAD_FINISHED,
> 
> I think reordering the signals is an ABI break unfortunatley.

I don't think so, the enum is only used internally isn't it?

> Source/WebKit/gtk/webkit/webkitwebview.cpp:205
> +    RESOURCE_LOADING_FINISHED,

And here...

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1051
> +static CString convertSoupURIToURLPath(SoupURI* uri)

How about pathFromSoupURI?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.