[Webkit-unassigned] [Bug 76611] Content element should be able to be dynamically added/removed/replaced in a shadow tree.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 30 18:42:08 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76611
--- Comment #14 from Shinya Kawanaka <shinyak at chromium.org> 2012-01-30 18:42:08 PST ---
(In reply to comment #12)
> (From update of attachment 124516 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124516&action=review
>
> > Source/WebCore/dom/Element.cpp:945
> > + // When a shadow root exists, attaching all children is due for the shadow root.
>
> Did you mean to say: "When a shadow root exists, it does the work of attaching the children." perhaps? Otherwise, the comment is a bit unclear.
Done.
>
> > Source/WebCore/dom/Element.cpp:947
> > + ContainerNode::attachAsNode();
>
> Can you not just call Node::attach() here?
>
> > Source/WebCore/dom/Element.cpp:978
> > + ContainerNode::detachAsNode();
>
> Node::detach()?
Done.
>
> > Source/WebCore/dom/ShadowRoot.h:46
> > + void setNeedsShadowTreeStyleRecalc() { m_needsShadowTreeStyleRecalc = true; }
> > + void clearNeedsShadowTreeStyleRecalc() { m_needsShadowTreeStyleRecalc = false; }
> > + bool needsShadowTreeStyleRecalc() { return m_needsShadowTreeStyleRecalc; }
>
> Usually, we implement inlines as full class function definition right below the class declaration.
Done.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list