[Webkit-unassigned] [Bug 75522] Enable IPP for FFTFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75522





--- Comment #27 from xingnan.wang at intel.com  2012-01-30 18:08:04 PST ---
(In reply to comment #26)
> (In reply to comment #25)
> > (From update of attachment 121959 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=121959&action=review
> > 
> > >>> Source/WebCore/WebCore.gyp/WebCore.gyp:51
> > >>> +    'use_system_ipp%': 1,
> > >> 
> > >> Do you mean for this to be enabled by default?  In what cases would we compile with WTF_USE_WEBAUDIO_IPP=1 and use_system_ipp = 0?
> > > 
> > > Now I just enable the system ipp, but I think it makes sense to add IPP to third_party in future and "use_system_ipp=0" is for such condition. Also some FIXMEs about it are added.
> > 
> > I would remove the use_system_ipp variable from this patch and just assume that if WTF_USE_WEBAUDIO_IPP=1, that we're using the system copy.  We can add the use_system_ipp variable after we've checked in a copy of ipp into third_party.
> 
> Sorry to make the review a little more complicated, but I'm not sure if we will be able to check the libraries into third_party, depending on the commercial license Intel provides for this (don't worry it's not GPL).  Xingnan, do you know any more details, or if Intel would be willing to open IPP up as a free license for WebKit?  For Chrome, we'd have to keep it in "chrome internal" somewhere, if not.
> 
> But (I think) Intel is interested in using this in general chromium (not Chrome-branded), so I don't know what the right approach is...

Hi Roger,

AFAIK, currently IPP is under commercial license, anyone uses it should buy it. So I don't think we can check it into third_party and share with community. 

But I think it is meaningful to put the IPP related information in gyp file. 

In this way, any user or company wants to build chromium with IPP can buy IPP and install it or put IPP library under third_party folder(just like MKL) and build chromium and then re-distribute the binary(maybe just like how chrome is build). 

As for free license for WebKit, it should be a business decision, which is out of our scope, we can contact with corresponding guys for this option, but currently I think the answer is no. thanks

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.