[Webkit-unassigned] [Bug 76685] Fix ASSERT fail within AudioBus::processWithGainFrom()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76685





--- Comment #9 from Raymond <rgbbones at gmail.com>  2012-01-30 17:12:46 PST ---
(In reply to comment #7)
> (From update of attachment 124491 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124491&action=review
> 
> Great test!  But I think the name of the test should be changed to "audionode-connect-order".  We shouldn't talk about "audiobus" in the layout tests because it is a low-level C++ class not exposed to the JS API.  The layout tests are meant to be (potentially) shared across browser implementations, so must hide these types of details and instead use terminology only exposed through the JS API.
> 
> > LayoutTests/webaudio/audiobus-assert.html:55
> > +    delay.connect(gain);
> 
> I think we should have a fairly detailed descriptive comment which explains that the test involves the *order* that we connect nodes.
> In this case, the delay node is connected to the gain node, *before* anything is connected to the delay node.  So this test is very much involved with the order of connections.

OK, patch updated ;)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.