[Webkit-unassigned] [Bug 77387] New: Avoid Page::updateViewportArguments() if the causing frame is not the main frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77387

           Summary: Avoid Page::updateViewportArguments() if the causing
                    frame is not the main frame
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: wangxianzhu at chromium.org
                CC: abarth at webkit.org, klobag at chromium.org


As Page::updateViewportArguments() only processes the ViewPortArguments of the main frame document, it's wasteful to call it from frame/document which is not the main frame/document.

I saw a crash in my local testing environment caused a call to the method from a subframe.
The call stack is like the following:

  FrameView::layout() (subframe) crashed because document is null
  ...
  FrameView::layout() (main frame)
  ...
  ScrollView::updateScrollbars()
  ...
  Page::updateViewportArguments()
  Frame::setDocument(0) (subframe)
  FrameLoader::clear()
  DocumentWriter::begin()
  ...

Will create a test case when have time.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.