[Webkit-unassigned] [Bug 18413] hixie test fails for CSS: sanity tests for relative keyword values of font-size

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18413


Xianzhu Wang <wangxianzhu at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|Normal                      |Minor
           Priority|P2                          |P4




--- Comment #30 from Xianzhu Wang <wangxianzhu at chromium.org>  2012-01-30 16:05:21 PST ---
(In reply to comment #29)
> (From update of attachment 94765 [details])
> Do we really need to add this massive function?  And there's no way we can share code with findNearestLegacyFontSize? It seems like what you want to do is fontSizeForKeyword(legacyFontSize(...) + increaseFontSize ? 1 : -1).

My first patch is older than findNearestLegacyFontSize(), and didn't notice it when making the later patches :)

By reusing findNearestLegacyFontSize(), the size of the function can only be reduced by a few lines. Most of the lines in relativeFontSize() handle the cases that the original font size is not in the table.

Canceled the review request because the patch is out-dated. Also lowered the priority and severity. Unlikely to get chance to work on it in the near future.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.