[Webkit-unassigned] [Bug 77350] New: All mouse events after a right click are ignored when they came from WebkitTestRunner

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77350

           Summary: All mouse events after a right click are ignored when
                    they came from WebkitTestRunner
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Event Handling
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: hugo.lima at openbossa.org


When a right click comes to WebCore and it realize that a context menu should pop up to the user it sends back a event telling the UI process to show the context menu, but as described in bug#58406, a mouse release event may already be in the CoreIPC pipeline because the UI sent it before receiving the "show context menu" event from WebProcess. To solve this issue the patch from bug#58406 added a flag to tell WebPage if it should ignore the mouse release event (or any other mouse events).

WebKitTestRunner send events synchronized, so the issue reported on bug#58406 doesn't affect WebKitTestRunner, besides due to the sync nature of WebKitTestRunner it will only receive the showContextMenu (that was sent async) after it already sent all events, so all events sent after the right click event will be ignored by webcore.

The proposed patch removes the check when using synchronized events making some tests that are Skipped on many webkit2 ports pass. Another possible approach would send the showContextMenu/contextMenuHidden events sync, but contextMenuHidden is only used to fix bug#58406.

Please correct me if any assumptions I made are wrong.

Test now passing:
fast/events/mouse-click-events.html

Found on following skip lists:
qt-wk2/Skipped:57
efl/Skipped:1523
gtk/Skipped:839
mac-wk2/Skipped:146
win-wk2/Skipped:224

The patch only removes the test from qt-wk2 skip list, but it probably would make this test pass on other wk2 ports.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.