[Webkit-unassigned] [Bug 77085] [GStreamer] 0.11 build support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 09:48:34 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77085


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124089|review?                     |review+
               Flag|                            |




--- Comment #3 from Martin Robinson <mrobinson at webkit.org>  2012-01-30 09:48:34 PST ---
(From update of attachment 124089)
View in context: https://bugs.webkit.org/attachment.cgi?id=124089&action=review

Looks good, but fix the indentation and line breaking of the case statement.

> configure.ac:272
> +# determine the (optional) GStreamer version to use

You can just omit this.

> configure.ac:277
> +        [case "$with_gstreamer" in
> +        0.10|0.11) ;;

Your line breaks and indentation are a bit weird here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list