[Webkit-unassigned] [Bug 77089] [GStreamer] 0.11 support in MediaPlayerPrivateGStreamer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77089





--- Comment #5 from Philippe Normand <pnormand at igalia.com>  2012-01-30 03:12:49 PST ---
(In reply to comment #4)
> (From update of attachment 124094 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124094&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:979
> > +            gst_object_unref(pad);
> 
> Nope, g_value_unset() please :)
> 

Ouch!

> > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1802
> > +    GstElement* videoConvert = gst_element_factory_make("videoconvert", 0);
> 
> Why is this necessary in 1.0 only?

Oh hum yeah I don't remember why I added that, I'll check this part again. Thanks for the review!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.