[Webkit-unassigned] [Bug 77319] [EFL] Set content hint information for ewk_view_single.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 30 02:33:15 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=77319





--- Comment #7 from KwangHyuk <hyuki.kim at samsung.com>  2012-01-30 02:33:15 PST ---
(In reply to comment #2)
> (From update of attachment 124499 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124499&action=review
> 
> Patch itself looks good to me.
> 
> > Source/WebKit/efl/ewk/ewk_view_single.cpp:64
> > +    const std::string engine(ecore_evas_engine_name_get(ecoreEvas));
> > +    if (!engine.compare("opengl_x11"))
> 
> How do you think about using WebCore::String ?Why do

I agree that using WTF::String is more readable than std::string. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list