[Webkit-unassigned] [Bug 77148] [Qt][Texmap] Refactor TextureMapper API to use ImageBuffers when possible.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77148





--- Comment #13 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-30 01:34:15 PST ---
(From update of attachment 124497)
View in context: https://bugs.webkit.org/attachment.cgi?id=124497&action=review

> Source/WebCore/platform/graphics/GraphicsContext.h:420
> +#if PLATFORM(QT)
> +        void concatTransform(const TransformationMatrix&);
> +        void setTransform(const TransformationMatrix&);
> +        TransformationMatrix getTransform() const;
> +#else
> +        void concatTransform(const TransformationMatrix& transform) { concatCTM(transform.toAffine()); }
> +        void setTransform(const TransformationMatrix& transform) { setCTM(transform.toAffine()); }
> +        TransformationMatrix getTransform() const { return TransformationMatrix(getCTM()); }
> +#endif

Maybe a comment here would be nice to know why this is needed for Qt. Isn't it a bit confusing to have both concatTransform and concatCTM?

> Source/WebCore/platform/graphics/texmap/TextureMapper.cpp:121
> +
> +void BitmapTextureImageBuffer::updateContents(void* data, const IntRect& targetRect, PixelFormat format)
> +{

Maybe a comment here would be helpful for other ports?

> Source/WebCore/platform/graphics/texmap/TextureMapper.h:85
> +    enum AccelerationMode { Accelerated, Unaccelerated };

In the case someone adds native directx support some day, would Software, OpenGL make more sense?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:191
> +    // This suld be a reference copy only.

suld*?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.