[Webkit-unassigned] [Bug 75522] Enable IPP for FFTFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75522





--- Comment #24 from xingnan.wang at intel.com  2012-01-30 00:41:50 PST ---
(In reply to comment #22)
> (From update of attachment 121959 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121959&action=review
> 
> > Source/WebCore/WebCore.gyp/WebCore.gyp:51
> > +    # If set to 1, use the system IPP library, else use the thirdparty/ipp.
> > +    'use_system_ipp%': 1,
> 
> Do you mean for this to be enabled by default?  In what cases would we compile with WTF_USE_WEBAUDIO_IPP=1 and use_system_ipp = 0?
Now I just enable the system ipp, but I think it makes sense to add IPP to third_party in future and "use_system_ipp=0" is for such condition. Also some FIXMEs about it are added.
> 
> > Source/WebCore/WebCore.gyp/WebCore.gyp:1169
> > +        ['OS=="linux" and "WTF_USE_WEBAUDIO_IPP=1" in feature_defines', {
> > +          'conditions': [
> > +              ['use_system_ipp == 1', {
> 
> If possible, I would prefer 1 flag rather than 2 (WTF_USE_WEBAUDIO_IPP and use_system_ipp).
> 
If ipp could be enabled in third_party, the 2 flag are all needed. 
> > Source/WebCore/WebCore.gyp/WebCore.gyp:1171
> > +                      '/opt/intel/ipp/include',
> 
> Is this always in the same location?  Does the library come with a pkgconfig file that we can query instead?  See other examples of how we check for system libraries in src/build/linux/system.gyp.
> 
That`s right, I`ll use pkg-config.
> > Source/WebKit/chromium/features.gypi:154
> >        ['OS!="mac"', {
> >          'feature_defines': [
> >            'WTF_USE_WEBAUDIO_FFMPEG=1',
> > +          'WTF_USE_WEBAUDIO_IPP=0',
> 
> Will this be used on mac too?
Now I just enabled IPP in linux and "OS==linux" should be considered.
IPP is not used as default so just removing this line is OK.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.