[Webkit-unassigned] [Bug 76761] [BlackBerry] Credential backing store implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76761


Antonio Gomes <tonikitoo at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124484|review?                     |review+
               Flag|                            |




--- Comment #4 from Antonio Gomes <tonikitoo at webkit.org>  2012-01-29 20:49:50 PST ---
(From update of attachment 124484)
View in context: https://bugs.webkit.org/attachment.cgi?id=124484&action=review

it loosk good, r+

Please re-upload with the suggestions addressed if you think they are convenient, and add "Reviewed by Antonio Gomes" to the new patch/changelog. No need to another review round, only cq+ needed.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:70
> +        // Create table logins

I would drop this comment. it looks unneeded given the line below it. Also lacks a "." at the end :-)

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:74
> +        // Create index for table logins

ditto

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:77
> +    } else { // Initiate CredentialStorage

. in the end

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.