[Webkit-unassigned] [Bug 76611] Content element should be able to be dynamically added/removed/replaced in a shadow tree.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76611





--- Comment #9 from MORITA Hajime <morrita at google.com>  2012-01-29 20:16:24 PST ---
(From update of attachment 123922)
View in context: https://bugs.webkit.org/attachment.cgi?id=123922&action=review

> Source/WebCore/dom/ContainerNode.cpp:790
> +void ContainerNode::attachWithoutChildren()

Could you inline this?

> Source/WebCore/dom/ContainerNode.cpp:806
> +}

And this?

> Source/WebCore/dom/ContainerNode.h:78
> +    void detachWithoutChildren();

"WithoutChildren" sounds a bit confusing as many negative-adjectives are. Maybe attachAsNode() ?

> Source/WebCore/dom/ShadowRoot.h:75
> +    bool m_needsShadowTreeStyleRecalc;

Let's turn these boolean variables bit-fields.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.