[Webkit-unassigned] [Bug 75522] Enable IPP for FFTFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75522





--- Comment #22 from Tony Chang <tony at chromium.org>  2012-01-29 18:41:37 PST ---
(From update of attachment 121959)
View in context: https://bugs.webkit.org/attachment.cgi?id=121959&action=review

> Source/WebCore/WebCore.gyp/WebCore.gyp:51
> +    # If set to 1, use the system IPP library, else use the thirdparty/ipp.
> +    'use_system_ipp%': 1,

Do you mean for this to be enabled by default?  In what cases would we compile with WTF_USE_WEBAUDIO_IPP=1 and use_system_ipp = 0?

> Source/WebCore/WebCore.gyp/WebCore.gyp:1169
> +        ['OS=="linux" and "WTF_USE_WEBAUDIO_IPP=1" in feature_defines', {
> +          'conditions': [
> +              ['use_system_ipp == 1', {

If possible, I would prefer 1 flag rather than 2 (WTF_USE_WEBAUDIO_IPP and use_system_ipp).

> Source/WebCore/WebCore.gyp/WebCore.gyp:1171
> +                      '/opt/intel/ipp/include',

Is this always in the same location?  Does the library come with a pkgconfig file that we can query instead?  See other examples of how we check for system libraries in src/build/linux/system.gyp.

> Source/WebKit/chromium/features.gypi:154
>        ['OS!="mac"', {
>          'feature_defines': [
>            'WTF_USE_WEBAUDIO_FFMPEG=1',
> +          'WTF_USE_WEBAUDIO_IPP=0',

Will this be used on mac too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.