[Webkit-unassigned] [Bug 76370] [EFL] Define the names of view smart class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76370





--- Comment #17 from Eunsol Park <eunsol47.park at samsung.com>  2012-01-29 17:52:02 PST ---
(In reply to comment #15)
> (From update of attachment 122889 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122889&action=review
> 
> > Source/WebKit/efl/ewk/ewk_view.cpp:270
> > -    if (!evas_object_smart_type_check(ewkView, "Ewk_View_Tiled")) { \
> > -        INF("object is not a instance of Ewk_View_Tiled"); \
> > +    if (!evas_object_smart_type_check(ewkView, ewkViewTiledName)) { \
> > +        INF("object isn't an instance of ewkViewTiledName"); \
> 
> Seems like the second line should be:
> INF("object isn't an instance of " ewkViewTiledName); \
> 
> As you don't want the variable name to leak into error messages.

I've done it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.