[Webkit-unassigned] [Bug 76370] [EFL] Define the names of view smart class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 27 03:48:46 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76370





--- Comment #15 from Andreas Kling <kling at webkit.org>  2012-01-27 03:48:46 PST ---
(From update of attachment 122889)
View in context: https://bugs.webkit.org/attachment.cgi?id=122889&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:270
> -    if (!evas_object_smart_type_check(ewkView, "Ewk_View_Tiled")) { \
> -        INF("object is not a instance of Ewk_View_Tiled"); \
> +    if (!evas_object_smart_type_check(ewkView, ewkViewTiledName)) { \
> +        INF("object isn't an instance of ewkViewTiledName"); \

Seems like the second line should be:
INF("object isn't an instance of " ewkViewTiledName); \

As you don't want the variable name to leak into error messages.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list