[Webkit-unassigned] [Bug 67109] [EFL] Queued scroll feature
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 27 03:11:26 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=67109
--- Comment #21 from KwangHyuk <hyuki.kim at samsung.com> 2012-01-27 03:11:26 PST ---
(In reply to comment #20)
> (In reply to comment #18)
> > > Source/WebKit/efl/ewk/ewk_frame.cpp:794
> > > + if (!smartData->queuedScrolls.idler)
> >
> > Unfortunately, idler callback can cause two issues.
> > Idler callback can not be called when cpu is busy and it can cause crash if object is destroyed and callback isn't unregistered.
> > In addition, current implementation may not apply final scroll request.
> > What do you think ?
>
> Yes, looks like you are right :) I added ecore_idler_del inside _ewk_frame_smart_del().
Ok for the change,
But, finally, I hope that you will consider the things below one more time,
- Doesn't it matter if idler callback isn't called for a while while panning on page-loading ?
- Would it be ok although calling of callback is pending, so smartData->queuedScrolls.idler won't be 0 for a long time ?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list