[Webkit-unassigned] [Bug 76987] [EFL] Add API to get tile size.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 26 20:58:18 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76987





--- Comment #5 from Ryuan Choi <ryuan.choi at samsung.com>  2012-01-26 20:58:18 PST ---
(From update of attachment 123894)
View in context: https://bugs.webkit.org/attachment.cgi?id=123894&action=review

> Source/WebKit/efl/ChangeLog:9
> +        So that we can calcualte viewport attributes by ROUNDED_ZOOM macro and tile size in future implementation.

s/calcualte/calculate

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:2049
> +void ewk_tiled_backing_store_tile_size_get(const Evas_Object* ewkBackingStore, Evas_Coord* tileWidth, Evas_Coord* tileHeight)

Can we use int instead of Evas_Coord for internal functions ?

And how do you think about using IntSize ?

> Source/WebKit/efl/ewk/ewk_view_tiled.cpp:407
> +void ewk_view_tiled_tile_size_get(const Evas_Object* ewkView, Evas_Coord* tileWidth, Evas_Coord* tileHeight)

If other files will use this function, why don't you add it in ewk_private.h or proper headers?

Is it to use only in ewk_view_tiled.cpp?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list