[Webkit-unassigned] [Bug 77177] Tools/Scripts/change-log-editor is broken due to $_ getting clobbered

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=77177


Jon Honeycutt <jhoneycutt at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #124244|review?                     |review+
               Flag|                            |




--- Comment #3 from Jon Honeycutt <jhoneycutt at apple.com>  2012-01-26 20:06:52 PST ---
(From update of attachment 124244)
View in context: https://bugs.webkit.org/attachment.cgi?id=124244&action=review

> Tools/ChangeLog:3
> +        Tools/Scripts/change-log-editor is broken due to $_ getting clobbered

change-log-editor -> commit-log-editor

> Tools/Scripts/commit-log-editor:136
>  while (<LOG>) {
> +    my $curLine = $_;

You could do while (my $curLine = <LOG>) {

> Tools/Scripts/commit-log-editor:145
> +    if (!isGit() || $curLine =~ /^#/) { #

Could remove this EOL comment while you're here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.