[Webkit-unassigned] [Bug 76995] WebKit fails IETC :indeterminate and input type=radio test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 26 08:32:14 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76995





--- Comment #14 from Joe Thomas <joethomas at motorola.com>  2012-01-26 08:32:14 PST ---
(In reply to comment #10)
> (From update of attachment 124061 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124061&action=review
> 
> > Source/WebCore/html/HTMLInputElement.cpp:949
> > -    if (!m_inputType->isCheckable() || indeterminate() == newValue)
> > +    if (!isCheckbox() || indeterminate() == newValue)
> 
> This is wrong.
> According to the specification, setter/getter of HTMLInputElement::indeterminate should work regardless of the type.  IE9, Firefox, and Opera work so.
> 
> As I already wrote, we need to update HTMLInputElement::isIndeterminate() so that :indeterminate pseudo class doesn't match to non-checkbox types.

Thanks for the review. Modified patch is attached.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list