[Webkit-unassigned] [Bug 73309] [Qt] GC should be parallel on Qt platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73309


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |zimmermann at kde.org
         Depends on|77090                       |




--- Comment #60 from Nikolas Zimmermann <zimmermann at kde.org>  2012-01-26 03:50:19 PST ---
(In reply to comment #59)
> (From update of attachment 124070 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=124070&action=review
> 
> > Source/JavaScriptCore/wtf/MainThread.cpp:254
> > +static ThreadSpecific<bool>* isGCThread;
> 
> This breaks the world on mac. isGCThread is still defined in MainThreadMac.mm.
> initializeGCThreading creates the one in MainThreadMac.mm, but this ThreadSpecific is never initialized!
> I don't get how this can work for you?

I suggest you move initializeGCThreading() from MainThreadMac.mm to MainThread.cpp.
But you also have to call them somewhere from the Qt platform code, otherwise it'll still crash random for you - as it does now in trunk with this patch applied.

I'm rolling it out for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.