[Webkit-unassigned] [Bug 67388] [Qt][WK2] fast/loader tests failed after r94178

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67388





--- Comment #3 from Simon Hausmann <hausmann at webkit.org>  2012-01-26 01:04:01 PST ---
(From update of attachment 124004)
View in context: https://bugs.webkit.org/attachment.cgi?id=124004&action=review

> Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:92
> +    QString localTmpUrl(QLatin1String("file:///tmp/LayoutTests"));

Since this is Qt 5 it's better to write:

QString localTmpUrl(QStringLiteral("..."));

> Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:93
> +    QString givenUrl(QString(reinterpret_cast<const QChar*>(JSStringGetCharactersPtr(url)), JSStringGetLength(url)));

Why call the QString constructor twice? Can't you simply write:

QString givenUrl(reinterpret_cast..., ...);

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.