[Webkit-unassigned] [Bug 42545] WebKitTestRunner needs layoutTestController.setGeolocationPermission

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=42545





--- Comment #12 from Simon Hausmann <hausmann at webkit.org>  2012-01-26 00:21:38 PST ---
(From update of attachment 123731)
View in context: https://bugs.webkit.org/attachment.cgi?id=123731&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:73
> +WK_EXPORT void WKBundlesetGeolocationPermission(WKBundleRef bundle, WKBundlePageGroupRef pageGroup, bool enabled);

WKBundlesetGeolocationPermission -> WKBundle_S_etGeolocationPermission

> Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:171
> +        (static_cast<GeolocationClientMock*>((*iter)->geolocationController()->client()))->setPermission(enabled);

I think you can remove the parentheses around the static_cast, i.e. write

    static_cast<Foo*>(bar)->blub();

instead of

    (static_cast<Foo*>(bar))->blub();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.