[Webkit-unassigned] [Bug 76248] Initial implementation of GraphicsContext3DOpenGLES.cpp

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76248





--- Comment #10 from ChangSeok Oh <kevin.cs.oh at gmail.com>  2012-01-26 00:15:48 PST ---
(In reply to comment #8)
> (From update of attachment 122730 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122730&action=review
> 
> >> Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:133
> >> +        ::glBindRenderbufferEXT(GL_RENDERBUFFER_EXT, 0);
> > 
> > OpenGL ES also has the concept of a packed depth/stencil buffer as well -- see the GL_OES_packed_depth_stencil extension. If you used that you could share setting up the single-sample framebuffer with the desktop implementation. If, for some reason, that's not an option (your target device does not support packed depth/stencil), then at the very least you should consider avoiding calling ::glBindRenderbufferEXT(GL_RENDERBUFFER_EXT, 0) twice in a row here.
> 
> Hm. To tell you the truth. I haven't know about GL_OES_packed_depth_stencil extension. I need more time to research and test it. :p. Here I opened a new bug to support it. http://webkit.org/b/77011
> Removed  calling ::glBindRenderbufferEXT twice.

My target looks like supporting GL_OES_packed_depth_stencil. So I've updated the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.