[Webkit-unassigned] [Bug 68618] btoa() and atob() should stringify null to "null", not ""

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68618


Kentaro Hara <haraken at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #118190|commit-queue?               |commit-queue-
               Flag|                            |




--- Comment #5 from Kentaro Hara <haraken at chromium.org>  2012-01-25 18:21:27 PST ---
(From update of attachment 118190)
View in context: https://bugs.webkit.org/attachment.cgi?id=118190&action=review

The change looks OK to me.

> Source/WebCore/ChangeLog:5
> +

Would you add some explanation about this change? At least the link to the spec, please.

> LayoutTests/ChangeLog:5
> +

Would you add some explanation about this change? At least the link to the spec, please.

> LayoutTests/fast/dom/Window/atob-btoa.html:25
> +shouldBe('window.btoa(null)', '"bnVsbA=="');
>  shouldBe('window.btoa(undefined)', '"dW5kZWZpbmVk"');

Shall we add the following test cases?

    shouldBe('window.btoa("null")', '"bnVsbA=="');
    shouldBe('window.btoa("undefined")', '"dW5kZWZpbmVk"');

> LayoutTests/fast/dom/Window/atob-btoa.html:35
>  shouldThrow('window.atob()'); // 'undefined' 

Can you remove the comment "// 'undefined'"?

> LayoutTests/fast/dom/Window/atob-btoa.html:38
> +shouldBe('window.atob(null)', '"žée"');
>  shouldThrow('window.atob(undefined)');

Shall we add the following test cases?

    shouldBe('window.atob("null")', '"žée"');
    shouldThrow('window.atob("undefined")');

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.