[Webkit-unassigned] [Bug 76035] Add state attribute to history's dom interface.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 25 17:07:05 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76035
--- Comment #62 from Brady Eidson <beidson at apple.com> 2012-01-25 17:07:04 PST ---
Oliver and I talked it over. Here's how we thing we should make this work.
- Currently the attribute on PopStateEvent.idl is a DOMObject. This is wrong and it needs to be a SerializedScriptValue.
- The new attribute should not be a DOMObject. It needs to be a SerializedScriptValue.
- We need to use the IDL attributes "CachedAttribute, CustomGetter". CachedAttribute is what makes the JS wrapper for the SerializedScriptValue cached so it hangs around.
- We need to change PopStateEvent.h/cpp to be created with a History object, or at the very least a Frame object.
- JSPopStateEvent::state will grab the relevant History object from the PopStateEvent implementationg, do a cached lookup for the JSHistory wrapper of that History, and just call its JSHistory::state.
Oliver, did I get the plan right?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list