[Webkit-unassigned] [Bug 76886] [WK2][Qt] REGRESSION: Pages with transform animations sometimes omit some of the layers since r105413

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76886





--- Comment #5 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-25 14:37:43 PST ---
(From update of attachment 124012)
View in context: https://bugs.webkit.org/attachment.cgi?id=124012&action=review

Seems ok to me

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:551
> +    // If this layer is part of an active transform animation, the visible rect might change, so we rather render the whole layer
> +    // until some better optimization is available.

I would break the line after the second ,. Then they will have almost the same size

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:553
> +    if (selfOrAncestorHasActiveTransformAnimations())
> +        return tiledBackingStoreContentsRect();

Did you do some measurements of this? regarding to the comment in the changelog

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:725
> +    if (!parent())
> +        return false;
> +    return toWebGraphicsLayer(parent())->selfOrAncestorHasActiveTransformAnimations();

wouldnt it read nicer

if (parent())
    return toWeb....parent()...

return false;

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.