[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215


Kenneth Rohde Christiansen <kenneth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123943|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #42 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-25 12:43:17 PST ---
(From update of attachment 123943)
View in context: https://bugs.webkit.org/attachment.cgi?id=123943&action=review

Getting there, maybe Simon should have a look more.

I think the changelogs could be a bit more elaborate... ie. explain what it really adds, and maybe how it is implemented (ie why use a QUrl inside)

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:101
> +QDataStream& operator<<(QDataStream& out, const QtWebSecurityOrigin &origin)
> +{
> +    out.setVersion(QDataStream::Qt_4_0);
> +    out << (origin.url().toEncoded().data());
> +    return out;
> +}

hmm, is this correct simon?

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:58
> +
> +    enum OriginPolicyFlags {
> +        ContentHasSameOriginAccess = 0x0,
> +        LocalContentHasRemoteAccess = 0x1,
> +        LocalContentHasSystemLocalAccess = 0x2
> +    };

This is dead code for now, remove.

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:61
> +private:
> +    bool isLocalScheme(const QString&);

Is it ok to not have this in a private class?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.