[Webkit-unassigned] [Bug 76378] [EFL] Modify the code to webkit-style and adapt to C++ naming.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 25 08:33:50 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76378





--- Comment #24 from JungJik Lee <jungjik.lee at samsung.com>  2012-01-25 08:33:49 PST ---
(In reply to comment #23)
> (In reply to comment #21)
> > (In reply to comment #20)
> > > (In reply to comment #19)
> > > > I looked it over quickly, it is almost over 2000 lines. I think it can not be reviewed.
> > > 
> > > Something smells weird then. We've already gone through no less than 8 bug reports changing the coding style (besides the previous ones which got reverted, contributing to make the history mess even worse).
> > > 
> > > Were the changes you are proposing (and the ones not included in this patch) supposed to be part of any of the bugs which blocked bug 68209?
> > 
> > I read the blocked patches and there are no duplicated code with mine. So I think this patch is still valid. If you are worrying about messing up the history, I will try to join everything together to one patch by adding more.
> 
> If you have an overall idea of what kind of changes are still needed (eg. '*' location, variable naming etc), please tell us so we can discuss whether it makes more sense to commit everything at once or not.

Sure, I will inform you about this patch or similar implementation in future via mailing-list, IRC or email. Before I compete this patch, I will ask your opinion.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list