[Webkit-unassigned] [Bug 77005] [GStreamer] 0.11 support for Media elements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 25 08:06:02 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=77005
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com> 2012-01-25 08:06:03 PST ---
Attachment 123944 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebCore/ChangeLog', u..." exit_code: 1
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:67: webkit_video_sink_signals is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:71: timeout_id is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:72: buffer_mutex is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:73: data_cond is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:331: need_pool is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:362: n_param_values is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:363: invocation_hint is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:387: gobject_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:388: gstbase_sink_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer1.cpp:389: element_class is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 10 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list