[Webkit-unassigned] [Bug 70107] Custom written CSS lexer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70107





--- Comment #61 from Antti Koivisto <koivisto at iki.fi>  2012-01-25 07:13:59 PST ---
(In reply to comment #57)
> > Source/WebCore/css/CSSParser.cpp:181
> > +static inline UChar lowercaseCharacter(UChar chr)
> 
> "chr"? Please don't abbreviate like this.

I disagree with this comment. In type of code where a few variable names are repeated a lot (like parsers) using shorter names improves readability. We use 'i' instead of 'index' as the standard loop variable name for the same reason.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.