[Webkit-unassigned] [Bug 76816] Implement the URL decomposition IDL attributes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76816





--- Comment #6 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2012-01-24 23:03:32 PST ---
(In reply to comment #5)
> Why not just:
> 
> m_href = KURL(KURL(KURL(), baseURL), url);
> 
OK. Fixed this.

> > > Should this code be shared with Location and HTMLAnchorElement?
> > 
> > I am not sure how we can share the code.
> 
> This code looks very similar:
> 
> http://trac.webkit.org/browser/trunk/Source/WebCore/page/Location.cpp#L74
> 
> Perhaps we need a common base class?  Maybe a small object to composite into these classes?  The thing we're trying to avoid is to have the same logic repeated in multiple places ("Don't Repeat Yourself").

Yes I agree there are many functions which can be shared across DOMURL, HTMLAnchorElement and Location. But, IMHO, if you allow, I can address this creation of base class or may be even a interface to create shared functions for all these 3 classes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.