[Webkit-unassigned] [Bug 73156] [Microdata] Implement HTMLPropertiesCollection collection.namedItem()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73156


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #116969|review?                     |review-
               Flag|                            |




--- Comment #11 from Adam Barth <abarth at webkit.org>  2012-01-24 22:25:24 PST ---
(From update of attachment 116969)
View in context: https://bugs.webkit.org/attachment.cgi?id=116969&action=review

This patch confused me.  It looks like there's a bunch of extra code in here that we don't need anymore.  Am I confused?

> Source/WebCore/html/HTMLPropertiesCollection.cpp:202
> +    // FIXME: HTML5 specifies that this should return PropertyNodeList.
> +    return !namedItems.isEmpty() ? StaticNodeList::adopt(namedItems) : 0;

So, the nodelist this returns isn't live?  It's just static?

> Source/WebCore/html/HTMLPropertiesCollection.h:54
> +    bool canGetItemsForName(const String& name) const;

I'm confused.  Who calls this function?

> Source/WebCore/html/HTMLPropertiesCollection.idl:44
> +        NodeList namedItem(in DOMString name);

This isn't marked Custom anymore, but you still have the custom bindings code in your patch.  Can we remove that code?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.